mirrors/ParkanPlayground
0
Fork 0
mirror of https://github.com/sampletext32/ParkanPlayground.git synced 2025-06-20 08:18:36 +03:00
Code Issues Releases Activity

Simplified instruction handlers for better maintainability and consistency. Fixed operand size handling in XOR handlers with 16-bit registers. Added support for 6-byte NOP variant. Fixed formatting of immediate values to maintain consistent output.

Browse Source
This commit is contained in:
bird_egop
2025-04-13 23:15:11 +03:00
parent 11a2cfada4
commit cf1e1acf71
3 changed files with 18 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
X86Disassembler/X86/Handlers/Add/AddEaxImmHandler.cs
View File

@ -34,56 +34,25 @@ public class AddEaxImmHandler : InstructionHandler
/// <returns>True if the instruction was successfully decoded</returns>
public override bool Decode(byte opcode, Instruction instruction)
{
// Save the original position for raw bytes calculation
int startPosition = Decoder.GetPosition();
// Set the mnemonic
instruction.Mnemonic = "add";
// Check if we have enough bytes for the immediate value
if (startPosition + 4 > Length)
{
// Not enough bytes for the immediate value
instruction.Operands = "eax, ??";
// Set the raw bytes to just the opcode
instruction.RawBytes = new byte[] { opcode };
return true; // Still return true as we've set a valid mnemonic and operands
}
int position = Decoder.GetPosition();
// Check for special cases where the immediate value might be part of another instruction
// For example, if the next byte is 0x83 (Group 1 sign-extended immediate)
// or 0xEB (JMP rel8), it's likely the start of a new instruction
byte nextByte = CodeBuffer[startPosition];
if (nextByte == 0x83 || nextByte == 0xEB)
// Check if we have enough bytes for the immediate value
if (position + 3 >= Length)
{
// This is likely the start of a new instruction, not part of our immediate value
instruction.Operands = "eax, ??";
// Set the raw bytes to just the opcode
instruction.RawBytes = new byte[] { opcode };
return true;
return false; // Not enough bytes for the immediate value
}
// Read the 32-bit immediate value
uint imm32 = Decoder.ReadUInt32();
// Set the operands
instruction.Operands = $"eax, 0x{imm32:X8}";
// Format the immediate value
string immStr = $"0x{imm32:X}";
// Set the raw bytes
byte[] rawBytes = new byte[5]; // opcode + 4 bytes for immediate
rawBytes[0] = opcode;
for (int i = 0; i < 4; i++)
{
if (startPosition + i < Length)
{
rawBytes[i + 1] = CodeBuffer[startPosition + i];
}
}
instruction.RawBytes = rawBytes;
// Set the operands
instruction.Operands = $"eax, {immStr}";
return true;
}