mirrors/ParkanPlayground
0
Fork 0
mirror of https://github.com/sampletext32/ParkanPlayground.git synced 2025-06-20 16:18:37 +03:00
Code Issues Releases Activity

Improved PUSH handlers by moving reg field check to CanHandle and adding proper boundary checking

Browse Source
This commit is contained in:
bird_egop
2025-04-14 00:33:39 +03:00
parent 53696a9f1c
commit e134452eda
3 changed files with 39 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
X86Disassembler/X86/Handlers/Push/PushImm32Handler.cs
View File

@ -11,11 +11,11 @@ public class PushImm32Handler : InstructionHandler
/// <param name="codeBuffer">The buffer containing the code to decode</param>
/// <param name="decoder">The instruction decoder that owns this handler</param>
/// <param name="length">The length of the buffer</param>
public PushImm32Handler(byte[] codeBuffer, InstructionDecoder decoder, int length)
public PushImm32Handler(byte[] codeBuffer, InstructionDecoder decoder, int length)
: base(codeBuffer, decoder, length)
{
}
/// <summary>
/// Checks if this handler can decode the given opcode
/// </summary>
@ -25,7 +25,7 @@ public class PushImm32Handler : InstructionHandler
{
return opcode == 0x68;
}
/// <summary>
/// Decodes a PUSH imm32 instruction
/// </summary>
@ -37,9 +37,14 @@ public class PushImm32Handler : InstructionHandler
// Set the mnemonic
instruction.Mnemonic = "push";
if(!Decoder.CanReadUInt())
{
return false;
}
// Read the immediate value
uint imm32 = Decoder.ReadUInt32();
// Set the operands with 8-digit padding to match test expectations
instruction.Operands = $"0x{imm32:X8}";