mirrors/ParkanPlayground
0
Fork 0
mirror of https://github.com/sampletext32/ParkanPlayground.git synced 2025-06-19 16:08:02 +03:00
Code Issues Releases Activity

Fixed TEST instruction handlers and tests. Updated TestImmWithRm8Handler and TestImmWithRm32Handler to properly check opcode in CanHandle and validate reg field in Decode. Improved test cases to use InstructionDecoder directly.

Browse Source
This commit is contained in:
bird_egop
2025-04-12 21:21:03 +03:00
parent bf5fcdd2ff
commit fe0b04f5a1
10 changed files with 330 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
X86DisassemblerTests/InstructionDecoderTests.cs
View File

@ -52,8 +52,8 @@ public class InstructionDecoderTests
// Assert
Assert.NotNull(instruction);
Assert.Equal("test", instruction.Mnemonic);
// The actual implementation produces "al, cl" as the operands
Assert.Equal("al, cl", instruction.Operands);
// The correct operand order is TEST r/m8, r8 (TEST CL, AL)
Assert.Equal("cl, al", instruction.Operands);
Assert.Equal(2, instruction.RawBytes.Length);
Assert.Equal(0x84, instruction.RawBytes[0]);
Assert.Equal(0xC1, instruction.RawBytes[1]);
@ -76,8 +76,8 @@ public class InstructionDecoderTests
// Assert
Assert.NotNull(instruction);
Assert.Equal("test", instruction.Mnemonic);
// The actual implementation produces "eax, ecx" as the operands
Assert.Equal("eax, ecx", instruction.Operands);
// The correct operand order is TEST r/m32, r32 (TEST ECX, EAX)
Assert.Equal("ecx, eax", instruction.Operands);
Assert.Equal(2, instruction.RawBytes.Length);
Assert.Equal(0x85, instruction.RawBytes[0]);
Assert.Equal(0xC1, instruction.RawBytes[1]);
@ -176,7 +176,6 @@ public class InstructionDecoderTests
// Act - First instruction
var instruction1 = decoder.DecodeInstruction();
Debug.WriteLine($"After first instruction, decoder position: {decoder.GetPosition()}");
// Assert - First instruction
Assert.NotNull(instruction1);
@ -185,12 +184,11 @@ public class InstructionDecoderTests
// Act - Second instruction
var instruction2 = decoder.DecodeInstruction();
Debug.WriteLine($"After second instruction, decoder position: {decoder.GetPosition()}");
// Assert - Second instruction
Assert.NotNull(instruction2);
Assert.Equal("jz", instruction2.Mnemonic);
// The correct target address according to x86 architecture
Assert.Equal("0x00000032", instruction2?.Operands ?? string.Empty);
Assert.Equal("0x00000032", instruction2.Operands);
}
}