From 868eb1038162305b5e1e3193f6150173e9e95f2e Mon Sep 17 00:00:00 2001
From: WillyJL <49810075+Willy-JL@users.noreply.github.com>
Date: Sat, 12 Apr 2025 04:21:39 +0100
Subject: [PATCH] SDK: Fix missing RECORD_CLI define (#4185)

* SDK: Fix missing RECORD_CLI define

* sdk: added compatibility `cli.h` header

* cli: updated porting comments

---------

Co-authored-by: hedger <hedger@nanode.su>
---
 applications/services/cli/application.fam     |  2 +-
 applications/services/cli/cli.h               | 13 +++++++++++++
 applications/services/cli/cli_main_commands.h |  4 ++--
 targets/f18/api_symbols.csv                   |  1 +
 targets/f7/api_symbols.csv                    |  1 +
 5 files changed, 18 insertions(+), 3 deletions(-)
 create mode 100644 applications/services/cli/cli.h

diff --git a/applications/services/cli/application.fam b/applications/services/cli/application.fam
index 6e0a281649..b305fb6b0c 100644
--- a/applications/services/cli/application.fam
+++ b/applications/services/cli/application.fam
@@ -22,7 +22,7 @@ App(
     entry_point="cli_vcp_srv",
     stack_size=1024,
     order=10,
-    sdk_headers=["cli_vcp.h"],
+    sdk_headers=["cli_vcp.h", "cli.h"],
     sources=["cli_vcp.c"],
 )
 
diff --git a/applications/services/cli/cli.h b/applications/services/cli/cli.h
new file mode 100644
index 0000000000..ca787d3db6
--- /dev/null
+++ b/applications/services/cli/cli.h
@@ -0,0 +1,13 @@
+#pragma once
+
+/* 
+ * Compatibility header for ease of porting existing apps.
+ *  In short: 
+ *   Cli* is replaced with with CliRegistry*
+ *   cli_* functions are replaced with cli_registry_* functions
+ *   (i.e., cli_add_command() is now cli_registry_add_command())
+*/
+
+#include <toolbox/cli/cli_registry.h>
+
+#define RECORD_CLI "cli"
diff --git a/applications/services/cli/cli_main_commands.h b/applications/services/cli/cli_main_commands.h
index d8058f4677..ebee4ba1ed 100644
--- a/applications/services/cli/cli_main_commands.h
+++ b/applications/services/cli/cli_main_commands.h
@@ -1,9 +1,9 @@
 #pragma once
 
+#include "cli.h"
 #include <toolbox/cli/cli_command.h>
 #include <toolbox/cli/cli_registry.h>
 
-#define RECORD_CLI "cli"
-#define CLI_APPID  "cli"
+#define CLI_APPID "cli"
 
 void cli_main_commands_init(CliRegistry* registry);
diff --git a/targets/f18/api_symbols.csv b/targets/f18/api_symbols.csv
index d4cc2bec56..f1ebda5282 100644
--- a/targets/f18/api_symbols.csv
+++ b/targets/f18/api_symbols.csv
@@ -2,6 +2,7 @@ entry,status,name,type,params
 Version,+,85.0,,
 Header,+,applications/services/bt/bt_service/bt.h,,
 Header,+,applications/services/bt/bt_service/bt_keys_storage.h,,
+Header,+,applications/services/cli/cli.h,,
 Header,+,applications/services/cli/cli_vcp.h,,
 Header,+,applications/services/dialogs/dialogs.h,,
 Header,+,applications/services/dolphin/dolphin.h,,
diff --git a/targets/f7/api_symbols.csv b/targets/f7/api_symbols.csv
index f5f18bc43a..2e23dc56b7 100644
--- a/targets/f7/api_symbols.csv
+++ b/targets/f7/api_symbols.csv
@@ -3,6 +3,7 @@ Version,+,85.0,,
 Header,+,applications/drivers/subghz/cc1101_ext/cc1101_ext_interconnect.h,,
 Header,+,applications/services/bt/bt_service/bt.h,,
 Header,+,applications/services/bt/bt_service/bt_keys_storage.h,,
+Header,+,applications/services/cli/cli.h,,
 Header,+,applications/services/cli/cli_vcp.h,,
 Header,+,applications/services/dialogs/dialogs.h,,
 Header,+,applications/services/dolphin/dolphin.h,,