mirrors/flipperzero-firmware
1
Fork 0
mirror of https://github.com/flipperdevices/flipperzero-firmware.git synced 2025-12-12 20:59:50 +04:00
Code Issues Activity

Api Symbols: replace asserts with checks (#3507)

Browse Source 
* Api Symbols: replace asserts with checks
* Api Symbols: replace asserts with checks part 2
* Update no args function signatures with void, to help compiler to track incorrect usage
* More unavoidable void
* Update PVS config and code to make it happy
* Format sources
* nfc: fix checks
* dead code cleanup & include fixes

Co-authored-by: gornekich <n.gorbadey@gmail.com>
Co-authored-by: hedger <hedger@users.noreply.github.com>
Co-authored-by: hedger <hedger@nanode.su>
This commit is contained in:
あく
2024-03-19 23:43:52 +09:00
committed by GitHub
parent a09ec4d976
commit acc39a4bc0
571 changed files with 3565 additions and 2704 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
applications/services/rpc/rpc.c
View File

@@ -91,7 +91,7 @@ struct Rpc {
};
RpcOwner rpc_session_get_owner(RpcSession* session) {
furi_assert(session);
furi_check(session);
return session->owner;
}
@@ -112,7 +112,7 @@ static void rpc_close_session_process(const PB_Main* request, void* context) {
}
void rpc_session_set_context(RpcSession* session, void* context) {
furi_assert(session);
furi_check(session);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->context = context;
@@ -120,7 +120,7 @@ void rpc_session_set_context(RpcSession* session, void* context) {
}
void rpc_session_set_close_callback(RpcSession* session, RpcSessionClosedCallback callback) {
furi_assert(session);
furi_check(session);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->closed_callback = callback;
@@ -128,7 +128,7 @@ void rpc_session_set_close_callback(RpcSession* session, RpcSessionClosedCallbac
}
void rpc_session_set_send_bytes_callback(RpcSession* session, RpcSendBytesCallback callback) {
furi_assert(session);
furi_check(session);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->send_bytes_callback = callback;
@@ -138,7 +138,7 @@ void rpc_session_set_send_bytes_callback(RpcSession* session, RpcSendBytesCallba
void rpc_session_set_buffer_is_empty_callback(
RpcSession* session,
RpcBufferIsEmptyCallback callback) {
furi_assert(session);
furi_check(session);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->buffer_is_empty_callback = callback;
@@ -148,7 +148,7 @@ void rpc_session_set_buffer_is_empty_callback(
void rpc_session_set_terminated_callback(
RpcSession* session,
RpcSessionTerminatedCallback callback) {
furi_assert(session);
furi_check(session);
furi_mutex_acquire(session->callbacks_mutex, FuriWaitForever);
session->terminated_callback = callback;
@@ -166,8 +166,8 @@ size_t rpc_session_feed(
const uint8_t* encoded_bytes,
size_t size,
uint32_t timeout) {
furi_assert(session);
furi_assert(encoded_bytes);
furi_check(session);
furi_check(encoded_bytes);
if(!size) return 0;
@@ -179,7 +179,7 @@ size_t rpc_session_feed(
}
size_t rpc_session_get_available_size(RpcSession* session) {
furi_assert(session);
furi_check(session);
return furi_stream_buffer_spaces_available(session->stream);
}
@@ -383,7 +383,7 @@ static void rpc_session_thread_state_callback(FuriThreadState thread_state, void
}
RpcSession* rpc_session_open(Rpc* rpc, RpcOwner owner) {
furi_assert(rpc);
furi_check(rpc);
RpcSession* session = malloc(sizeof(RpcSession));
session->callbacks_mutex = furi_mutex_alloc(FuriMutexTypeNormal);
@@ -421,8 +421,8 @@ RpcSession* rpc_session_open(Rpc* rpc, RpcOwner owner) {
}
void rpc_session_close(RpcSession* session) {
furi_assert(session);
furi_assert(session->rpc);
furi_check(session);
furi_check(session->rpc);
rpc_session_set_send_bytes_callback(session, NULL);
rpc_session_set_close_callback(session, NULL);