Merge remote-tracking branch 'OFW/dev' into dev

lib/toolbox/SConscript

@@ -29,6 +29,7 @@ env.Append(
         File("version.h"),
         File("float_tools.h"),
         File("tar/tar_archive.h"),
+        File("str_buffer.h"),
         File("stream/stream.h"),
         File("stream/file_stream.h"),
         File("stream/string_stream.h"),

lib/toolbox/cli/shell/cli_shell_completions.c

@@ -1,6 +1,6 @@
 #include "cli_shell_completions.h"
 
-ARRAY_DEF(CommandCompletions, FuriString*, FURI_STRING_OPLIST); // -V524
+ARRAY_DEF(CommandCompletions, FuriString*, FURI_STRING_OPLIST); // -V524 //-V658
 #define M_OPL_CommandCompletions_t() ARRAY_OPLIST(CommandCompletions)
 
 struct CliShellCompletions {

lib/toolbox/str_buffer.c

@@ -0,0 +1,18 @@
+#include "str_buffer.h"
+
+const char* str_buffer_make_owned_clone(StrBuffer* buffer, const char* str) {
+    char* owned = strdup(str);
+    buffer->n_owned_strings++;
+    buffer->owned_strings =
+        realloc(buffer->owned_strings, buffer->n_owned_strings * sizeof(const char*)); // -V701
+    buffer->owned_strings[buffer->n_owned_strings - 1] = owned;
+    return owned;
+}
+
+void str_buffer_clear_all_clones(StrBuffer* buffer) {
+    for(size_t i = 0; i < buffer->n_owned_strings; i++) {
+        free(buffer->owned_strings[i]);
+    }
+    free(buffer->owned_strings);
+    buffer->owned_strings = NULL;
+}

lib/toolbox/str_buffer.h

@@ -0,0 +1,47 @@
+/**
+ * @file str_buffer.h
+ * 
+ * Allows you to create an owned clone of however many strings that you need,
+ * then free all of them at once. Essentially the simplest possible append-only
+ * unindexable array of owned C-style strings.
+ */
+#pragma once
+
+#include <furi.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief StrBuffer instance
+ * 
+ * Place this struct directly wherever you want, it doesn't have to be `alloc`ed
+ * and `free`d.
+ */
+typedef struct {
+    char** owned_strings;
+    size_t n_owned_strings;
+} StrBuffer;
+
+/**
+ * @brief Makes a owned duplicate of the provided string
+ * 
+ * @param[in] buffer StrBuffer instance
+ * @param[in] str    Input C-style string
+ * 
+ * @returns C-style string that contains to be valid event after `str` becomes
+ *          invalid
+ */
+const char* str_buffer_make_owned_clone(StrBuffer* buffer, const char* str);
+
+/**
+ * @brief Clears all owned duplicates
+ * 
+ * @param[in] buffer StrBuffer instance
+ */
+void str_buffer_clear_all_clones(StrBuffer* buffer);
+
+#ifdef __cplusplus
+}
+#endif

lib/toolbox/strint.c

@@ -80,7 +80,7 @@ StrintParseError strint_to_uint64_internal(
 
         if(result > mul_limit) return StrintParseOverflowError;
         result *= base;
-        if(result > limit - digit_value) return StrintParseOverflowError;
+        if(result > limit - digit_value) return StrintParseOverflowError; //-V658
         result += digit_value;
 
         read_total++;