mirrors/unleashed-firmware
1
Fork 0
mirror of https://github.com/DarkFlippers/unleashed-firmware.git synced 2025-12-12 04:34:43 +04:00
Code Issues Activity

Furi: cleanup crash use (#3175)

Browse Source 
* Furi: optional message in furi_crash and furi_halt
* Consistent furi_crash use
* UnitTests: crash instead of assert
* furi: check: fixed macro for default arg
* unit_tests: fixed crashes everywhere
* lib: infrared: fixed PVS warnings
* furi: eliminated __FURI_ASSERT_MESSAGE_FLAG
* Furi: update check.h docs
* Furi: add check.h usage note
* Docs: grammar

---------

Co-authored-by: hedger <hedger@nanode.su>
This commit is contained in:
あく
2023-10-31 19:40:32 +09:00
committed by GitHub
parent c8180747db
commit 9af81ce8d0
37 changed files with 159 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
furi/core/check.c
View File

@@ -128,7 +128,7 @@ static void __furi_print_name(bool isr) {
}
}
FURI_NORETURN void __furi_crash() {
FURI_NORETURN void __furi_crash_implementation() {
__disable_irq();
GET_MESSAGE_AND_STORE_REGISTERS();
@@ -179,7 +179,7 @@ FURI_NORETURN void __furi_crash() {
__builtin_unreachable();
}
FURI_NORETURN void __furi_halt() {
FURI_NORETURN void __furi_halt_implementation() {
__disable_irq();
GET_MESSAGE_AND_STORE_REGISTERS();

32
furi/core/check.h
View File

@@ -28,39 +28,51 @@ extern "C" {
#define __FURI_CHECK_MESSAGE_FLAG (0x02)
/** Crash system */
FURI_NORETURN void __furi_crash();
FURI_NORETURN void __furi_crash_implementation();
/** Halt system */
FURI_NORETURN void __furi_halt();
FURI_NORETURN void __furi_halt_implementation();
/** Crash system with message. Show message after reboot. */
#define furi_crash(message) \
#define __furi_crash(message) \
do { \
register const void* r12 asm("r12") = (void*)message; \
asm volatile("sukima%=:" : : "r"(r12)); \
__furi_crash(); \
__furi_crash_implementation(); \
} while(0)
/** Crash system
*
* @param optional message (const char*)
*/
#define furi_crash(...) M_APPLY(__furi_crash, M_IF_EMPTY(__VA_ARGS__)((NULL), (__VA_ARGS__)))
/** Halt system with message. */
#define furi_halt(message) \
#define __furi_halt(message) \
do { \
register const void* r12 asm("r12") = (void*)message; \
asm volatile("sukima%=:" : : "r"(r12)); \
__furi_halt(); \
__furi_halt_implementation(); \
} while(0)
/** Halt system
*
* @param optional message (const char*)
*/
#define furi_halt(...) M_APPLY(__furi_halt, M_IF_EMPTY(__VA_ARGS__)((NULL), (__VA_ARGS__)))
/** Check condition and crash if check failed */
#define __furi_check(__e, __m) \
do { \
if(!(__e)) { \
furi_crash(__m); \
__furi_crash(__m); \
} \
} while(0)
/** Check condition and crash if failed
*
* @param condition to check
* @param optional message
* @param optional message (const char*)
*/
#define furi_check(...) \
M_APPLY(__furi_check, M_DEFAULT_ARGS(2, (__FURI_CHECK_MESSAGE_FLAG), __VA_ARGS__))
@@ -70,7 +82,7 @@ FURI_NORETURN void __furi_halt();
#define __furi_assert(__e, __m) \
do { \
if(!(__e)) { \
furi_crash(__m); \
__furi_crash(__m); \
} \
} while(0)
#else
@@ -86,7 +98,7 @@ FURI_NORETURN void __furi_halt();
* @warning only will do check if firmware compiled in debug mode
*
* @param condition to check
* @param optional message
* @param optional message (const char*)
*/
#define furi_assert(...) \
M_APPLY(__furi_assert, M_DEFAULT_ARGS(2, (__FURI_ASSERT_MESSAGE_FLAG), __VA_ARGS__))