Api Symbols: replace asserts with checks (#3507)

* Api Symbols: replace asserts with checks
* Api Symbols: replace asserts with checks part 2
* Update no args function signatures with void, to help compiler to track incorrect usage
* More unavoidable void
* Update PVS config and code to make it happy
* Format sources
* nfc: fix checks
* dead code cleanup & include fixes

Co-authored-by: gornekich <n.gorbadey@gmail.com>
Co-authored-by: hedger <hedger@users.noreply.github.com>
Co-authored-by: hedger <hedger@nanode.su>

targets/f18/api_symbols.csv

@@ -1,5 +1,5 @@
 entry,status,name,type,params
-Version,+,58.0,,
+Version,+,59.0,,
 Header,+,applications/services/bt/bt_service/bt.h,,
 Header,+,applications/services/cli/cli.h,,
 Header,+,applications/services/cli/cli_vcp.h,,
@@ -756,7 +756,7 @@ Function,+,cli_cmd_interrupt_received,_Bool,Cli*
 Function,+,cli_delete_command,void,"Cli*, const char*"
 Function,+,cli_getc,char,Cli*
 Function,+,cli_is_connected,_Bool,Cli*
-Function,+,cli_nl,void,
+Function,+,cli_nl,void,Cli*
 Function,+,cli_print_usage,void,"const char*, const char*, const char*"
 Function,+,cli_read,size_t,"Cli*, uint8_t*, size_t"
 Function,+,cli_read_timeout,size_t,"Cli*, uint8_t*, size_t, uint32_t"

targets/f18/furi_hal/furi_hal.c

@@ -6,7 +6,7 @@
 
 #define TAG "FuriHal"
 
-void furi_hal_init_early() {
+void furi_hal_init_early(void) {
     furi_hal_cortex_init_early();
     furi_hal_clock_init_early();
     furi_hal_bus_init_early();
@@ -19,7 +19,7 @@ void furi_hal_init_early() {
     furi_hal_rtc_init_early();
 }
 
-void furi_hal_deinit_early() {
+void furi_hal_deinit_early(void) {
     furi_hal_rtc_deinit_early();
     furi_hal_i2c_deinit_early();
     furi_hal_spi_config_deinit_early();
@@ -29,7 +29,7 @@ void furi_hal_deinit_early() {
     furi_hal_clock_deinit_early();
 }
 
-void furi_hal_init() {
+void furi_hal_init(void) {
     furi_hal_mpu_init();
     furi_hal_clock_init();
     furi_hal_random_init();

targets/f18/furi_hal/furi_hal_resources.c

@@ -144,7 +144,7 @@ static void furi_hal_resources_init_gpio_pins(GpioMode mode) {
     }
 }
 
-void furi_hal_resources_init_early() {
+void furi_hal_resources_init_early(void) {
     furi_hal_bus_enable(FuriHalBusGPIOA);
     furi_hal_bus_enable(FuriHalBusGPIOB);
     furi_hal_bus_enable(FuriHalBusGPIOC);
@@ -190,7 +190,7 @@ void furi_hal_resources_init_early() {
     furi_hal_resources_init_gpio_pins(GpioModeAnalog);
 }
 
-void furi_hal_resources_deinit_early() {
+void furi_hal_resources_deinit_early(void) {
     furi_hal_resources_init_input_pins(GpioModeAnalog);
     furi_hal_bus_disable(FuriHalBusGPIOA);
     furi_hal_bus_disable(FuriHalBusGPIOB);
@@ -200,7 +200,7 @@ void furi_hal_resources_deinit_early() {
     furi_hal_bus_disable(FuriHalBusGPIOH);
 }
 
-void furi_hal_resources_init() {
+void furi_hal_resources_init(void) {
     // Button pins
     furi_hal_resources_init_input_pins(GpioModeInterruptRiseFall);
 

targets/f18/furi_hal/furi_hal_resources.h

@@ -109,11 +109,11 @@ extern const GpioPin gpio_periph_power;
 extern const GpioPin gpio_usb_dm;
 extern const GpioPin gpio_usb_dp;
 
-void furi_hal_resources_init_early();
+void furi_hal_resources_init_early(void);
 
-void furi_hal_resources_deinit_early();
+void furi_hal_resources_deinit_early(void);
 
-void furi_hal_resources_init();
+void furi_hal_resources_init(void);
 
 /**
  * Get a corresponding external connector pin number for a gpio

targets/f18/furi_hal/furi_hal_spi_config.c

@@ -77,17 +77,17 @@ const LL_SPI_InitTypeDef furi_hal_spi_preset_1edge_low_2m = {
 
 FuriMutex* furi_hal_spi_bus_r_mutex = NULL;
 
-void furi_hal_spi_config_init_early() {
+void furi_hal_spi_config_init_early(void) {
     furi_hal_spi_bus_init(&furi_hal_spi_bus_d);
     furi_hal_spi_bus_handle_init(&furi_hal_spi_bus_handle_display);
 }
 
-void furi_hal_spi_config_deinit_early() {
+void furi_hal_spi_config_deinit_early(void) {
     furi_hal_spi_bus_handle_deinit(&furi_hal_spi_bus_handle_display);
     furi_hal_spi_bus_deinit(&furi_hal_spi_bus_d);
 }
 
-void furi_hal_spi_config_init() {
+void furi_hal_spi_config_init(void) {
     furi_hal_spi_bus_handle_init(&furi_hal_spi_bus_handle_sd_fast);
     furi_hal_spi_bus_handle_init(&furi_hal_spi_bus_handle_sd_slow);
 

targets/f18/furi_hal/furi_hal_version_device.c

@@ -1,33 +1,33 @@
 #include <furi_hal_version.h>
 
-bool furi_hal_version_do_i_belong_here() {
+bool furi_hal_version_do_i_belong_here(void) {
     return (furi_hal_version_get_hw_target() == 18) || (furi_hal_version_get_hw_target() == 0);
 }
 
-const char* furi_hal_version_get_model_name() {
+const char* furi_hal_version_get_model_name(void) {
     return "Flipper Nano";
 }
 
-const char* furi_hal_version_get_model_code() {
+const char* furi_hal_version_get_model_code(void) {
     return "FN.1";
 }
 
-const char* furi_hal_version_get_fcc_id() {
+const char* furi_hal_version_get_fcc_id(void) {
     return "Pending";
 }
 
-const char* furi_hal_version_get_ic_id() {
+const char* furi_hal_version_get_ic_id(void) {
     return "Pending";
 }
 
-const char* furi_hal_version_get_mic_id() {
+const char* furi_hal_version_get_mic_id(void) {
     return "Pending";
 }
 
-const char* furi_hal_version_get_srrc_id() {
+const char* furi_hal_version_get_srrc_id(void) {
     return "Pending";
 }
 
-const char* furi_hal_version_get_ncc_id() {
+const char* furi_hal_version_get_ncc_id(void) {
     return "Pending";
 }