[FL-3757] NFC: fix application opening from browser (#3396)

* nfc_protocol_support_has_feature is now public

* Added function to show different scene depending on supported features of the device

* Fix delete button logic when selected from browser

* Fix rename button logic when selected from browser

* Update nfc_scene_save_success.c

---------

Co-authored-by: gornekich <n.gorbadey@gmail.com>
Co-authored-by: hedger <hedger@users.noreply.github.com>

applications/main/nfc/helpers/protocol_support/nfc_protocol_support.c

@@ -74,7 +74,7 @@ void nfc_protocol_support_on_exit(NfcProtocolSupportScene scene, void* context)
     nfc_protocol_support_scenes[scene].on_exit(instance);
 }
 
-static bool nfc_protocol_support_has_feature(NfcProtocol protocol, NfcProtocolFeature feature) {
+bool nfc_protocol_support_has_feature(NfcProtocol protocol, NfcProtocolFeature feature) {
     return nfc_protocol_support[protocol]->features & feature;
 }
 

applications/main/nfc/helpers/protocol_support/nfc_protocol_support.h

@@ -76,6 +76,7 @@
 #pragma once
 
 #include <gui/scene_manager.h>
+#include <lib/nfc/protocols/nfc_protocol.h>
 
 #include "nfc_protocol_support_common.h"
 
@@ -111,3 +112,5 @@ bool nfc_protocol_support_on_event(
  * @param[in,out] context pointer to a user-specified context (will be passed to concrete handler).
  */
 void nfc_protocol_support_on_exit(NfcProtocolSupportScene scene, void* context);
+
+bool nfc_protocol_support_has_feature(NfcProtocol protocol, NfcProtocolFeature feature);

applications/main/nfc/nfc_app.c

@@ -1,4 +1,5 @@
 #include "nfc_app_i.h"
+#include "helpers/protocol_support/nfc_protocol_support.h"
 
 #include <dolphin/dolphin.h>
 
@@ -475,6 +476,15 @@ static bool nfc_is_hal_ready() {
     }
 }
 
+static void nfc_show_initial_scene_for_device(NfcApp* nfc) {
+    NfcProtocol prot = nfc_device_get_protocol(nfc->nfc_device);
+    uint32_t scene = nfc_protocol_support_has_feature(
+                         prot, NfcProtocolFeatureEmulateFull | NfcProtocolFeatureEmulateUid) ?
+                         NfcSceneEmulate :
+                         NfcSceneSavedMenu;
+    scene_manager_next_scene(nfc->scene_manager, scene);
+}
+
 int32_t nfc_app(void* p) {
     if(!nfc_is_hal_ready()) return 0;
 
@@ -494,7 +504,7 @@ int32_t nfc_app(void* p) {
 
             furi_string_set(nfc->file_path, args);
             if(nfc_load_file(nfc, nfc->file_path, false)) {
-                scene_manager_next_scene(nfc->scene_manager, NfcSceneEmulate);
+                nfc_show_initial_scene_for_device(nfc);
             } else {
                 view_dispatcher_stop(nfc->view_dispatcher);
             }

applications/main/nfc/scenes/nfc_scene_delete.c

@@ -51,8 +51,11 @@ bool nfc_scene_delete_on_event(void* context, SceneManagerEvent event) {
             if(nfc_delete(nfc)) {
                 scene_manager_next_scene(nfc->scene_manager, NfcSceneDeleteSuccess);
             } else {
-                scene_manager_search_and_switch_to_previous_scene(
+                if(!scene_manager_search_and_switch_to_previous_scene(
-                    nfc->scene_manager, NfcSceneStart);
+                       nfc->scene_manager, NfcSceneStart)) {
+                    scene_manager_stop(nfc->scene_manager);
+                    view_dispatcher_stop(nfc->view_dispatcher);
+                }
             }
             consumed = true;
         }

applications/main/nfc/scenes/nfc_scene_delete_success.c

@@ -31,6 +31,11 @@ bool nfc_scene_delete_success_on_event(void* context, SceneManagerEvent event) {
             } else {
                 consumed = scene_manager_search_and_switch_to_previous_scene(
                     nfc->scene_manager, NfcSceneFileSelect);
+
+                if(!consumed) {
+                    scene_manager_stop(nfc->scene_manager);
+                    view_dispatcher_stop(nfc->view_dispatcher);
+                }
             }
         }
     }

applications/main/nfc/scenes/nfc_scene_save_success.c

@@ -31,12 +31,25 @@ bool nfc_scene_save_success_on_event(void* context, SceneManagerEvent event) {
             } else if(scene_manager_has_previous_scene(nfc->scene_manager, NfcSceneSaveConfirm)) {
                 scene_manager_next_scene(nfc->scene_manager, NfcSceneMfClassicDetectReader);
                 consumed = true;
+            } else if(scene_manager_has_previous_scene(nfc->scene_manager, NfcSceneSetType)) {
+                consumed = scene_manager_search_and_switch_to_another_scene(
+                    nfc->scene_manager, NfcSceneFileSelect);
+            } else if(scene_manager_has_previous_scene(nfc->scene_manager, NfcSceneReadSuccess)) {
+                consumed = scene_manager_search_and_switch_to_another_scene(
+                    nfc->scene_manager, NfcSceneFileSelect);
+            } else if(scene_manager_has_previous_scene(nfc->scene_manager, NfcSceneFileSelect)) {
+                consumed = scene_manager_search_and_switch_to_previous_scene(
+                    nfc->scene_manager, NfcSceneFileSelect);
+            } else if(scene_manager_has_previous_scene(nfc->scene_manager, NfcSceneSavedMenu)) {
+                consumed = scene_manager_search_and_switch_to_previous_scene(
+                    nfc->scene_manager, NfcSceneSavedMenu);
             } else {
                 consumed = scene_manager_search_and_switch_to_another_scene(
                     nfc->scene_manager, NfcSceneFileSelect);
             }
         }
     }
+
     return consumed;
 }