mirrors/unleashed-firmware
1
Fork 0
mirror of https://github.com/DarkFlippers/unleashed-firmware.git synced 2025-12-12 04:34:43 +04:00
Code Issues Activity

[FL-3488] Assign tickets to all TODO items (#2988)

Browse Source 
Co-authored-by: あく <alleteam@gmail.com>
This commit is contained in:
Astra
2023-08-23 02:56:27 +09:00
committed by GitHub
parent 200c44bdca
commit e353433cd8
66 changed files with 85 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/ibutton/ibutton_worker_modes.c
View File

@@ -127,7 +127,7 @@ void ibutton_worker_mode_write_blank_tick(iButtonWorker* worker) {
furi_assert(worker->key);
const bool success = ibutton_protocols_write_blank(worker->protocols, worker->key);
// TODO: pass a proper result to the callback
// TODO FL-3527: pass a proper result to the callback
const iButtonWorkerWriteResult result = success ? iButtonWorkerWriteOK :
iButtonWorkerWriteNoDetect;
if(worker->write_cb != NULL) {
@@ -139,7 +139,7 @@ void ibutton_worker_mode_write_copy_tick(iButtonWorker* worker) {
furi_assert(worker->key);
const bool success = ibutton_protocols_write_copy(worker->protocols, worker->key);
// TODO: pass a proper result to the callback
// TODO FL-3527: pass a proper result to the callback
const iButtonWorkerWriteResult result = success ? iButtonWorkerWriteOK :
iButtonWorkerWriteNoDetect;
if(worker->write_cb != NULL) {

4
lib/ibutton/protocols/blanks/rw1990.c
View File

@@ -62,7 +62,7 @@ bool rw1990_write_v1(OneWireHost* host, const uint8_t* data, size_t data_size) {
onewire_host_write_bit(host, true);
furi_delay_us(10000);
// TODO: Better error handling
// TODO FL-3528: Better error handling
return rw1990_read_and_compare(host, data, data_size);
}
@@ -90,6 +90,6 @@ bool rw1990_write_v2(OneWireHost* host, const uint8_t* data, size_t data_size) {
onewire_host_write_bit(host, false);
furi_delay_us(10000);
// TODO: Better error handling
// TODO Fl-3528: Better error handling
return rw1990_read_and_compare(host, data, data_size);
}

4
lib/ibutton/protocols/blanks/tm2004.c
View File

@@ -21,7 +21,7 @@ bool tm2004_write(OneWireHost* host, const uint8_t* data, size_t data_size) {
onewire_host_write(host, data[i]);
answer = onewire_host_read(host);
// TODO: check answer CRC
// TODO FL-3529: check answer CRC
// pulse indicating that data is correct
furi_delay_us(600);
@@ -37,6 +37,6 @@ bool tm2004_write(OneWireHost* host, const uint8_t* data, size_t data_size) {
}
}
// TODO: Better error handling
// TODO FL-3529: Better error handling
return i == data_size;
}

2
lib/ibutton/protocols/dallas/dallas_common.c
View File

@@ -149,7 +149,7 @@ bool dallas_common_emulate_search_rom(OneWireSlave* bus, const DallasCommonRomDa
if(!onewire_slave_send_bit(bus, !bit)) return false;
onewire_slave_receive_bit(bus);
// TODO: check for errors and return if any
// TODO FL-3530: check for errors and return if any
}
}

2
lib/ibutton/protocols/dallas/protocol_ds1971.c
View File

@@ -53,7 +53,7 @@ const iButtonProtocolDallasBase ibutton_protocol_ds1971 = {
.name = DS1971_FAMILY_NAME,
.read = dallas_ds1971_read,
.write_blank = NULL, // TODO: Implement writing to blank
.write_blank = NULL, // TODO FL-3531: Implement writing to blank
.write_copy = dallas_ds1971_write_copy,
.emulate = dallas_ds1971_emulate,
.save = dallas_ds1971_save,

2
lib/ibutton/protocols/dallas/protocol_ds1992.c
View File

@@ -73,7 +73,7 @@ bool dallas_ds1992_read(OneWireHost* host, iButtonProtocolData* protocol_data) {
bool dallas_ds1992_write_blank(OneWireHost* host, iButtonProtocolData* protocol_data) {
DS1992ProtocolData* data = protocol_data;
// TODO: Make this work, currently broken
// TODO FL-3532: Make this work, currently broken
return tm2004_write(host, (uint8_t*)data, sizeof(DallasCommonRomData) + DS1992_SRAM_DATA_SIZE);
}

2
lib/ibutton/protocols/dallas/protocol_ds1996.c
View File

@@ -159,7 +159,7 @@ static bool dallas_ds1996_command_callback(uint8_t command, void* context) {
case DALLAS_COMMON_CMD_MATCH_ROM:
case DALLAS_COMMON_CMD_OVERDRIVE_MATCH_ROM:
/* TODO: Match ROM command support */
/* TODO FL-3533: Match ROM command support */
default:
return false;
}