mirror of
https://github.com/DarkFlippers/unleashed-firmware.git
synced 2025-12-12 12:42:30 +04:00
* feat: FuriThread stdin * ci: fix f18 * feat: stdio callback context * feat: FuriPipe * POTENTIALLY EXPLOSIVE pipe welding * fix: non-explosive welding * Revert welding * docs: furi_pipe * feat: pipe event loop integration * update f18 sdk * f18 * docs: make doxygen happy * fix: event loop not triggering when pipe attached to stdio * fix: partial stdout in pipe * allow simultaneous in and out subscription in event loop * feat: vcp i/o * feat: cli ansi stuffs and history * feat: more line editing * working but slow cli rewrite * restore previous speed after 4 days of debugging 🥲 * fix: cli_app_should_stop * fix: cli and event_loop memory leaks * style: remove commented out code * ci: fix pvs warnings * fix: unit tests, event_loop crash * ci: fix build * ci: silence pvs warning * feat: cli gpio * ci: fix formatting * Fix memory leak during event loop unsubscription * Event better memory leak fix * feat: cli completions * Merge remote-tracking branch 'origin/dev' into portasynthinca3/3928-cli-threads * merge fixups * temporarily exclude speaker_debug app * pvs and unit tests fixups * feat: commands in fals * move commands out of flash, code cleanup * ci: fix errors * fix: run commands in buffer when stopping session * speedup cli file transfer * fix f18 * separate cli_shell into modules * fix pvs warning * fix qflipper refusing to connect * remove temp debug logs * remove erroneous conclusion * Fix memory leak during event loop unsubscription * Event better memory leak fix * unit test for the fix * improve thread stdio callback signatures * pipe stdout timeout * update api symbols * fix f18, formatting * fix pvs warnings * increase stack size, hope to fix unit tests * cli completions * more key combos * commands in fals * move commands out of flash * ci: fix errors * speedup cli file transfer * merge fixups * fix f18 * cli: revert flag changes * cli: fix formatting * cli, fbt: loopback perf benchmark * thread, event_loop: subscribing to thread flags * cli: signal internal events using thread flags, improve performance * fix f18, formatting * event_loop: fix crash * storage_cli: increase write_chunk buffer size again * cli: explanation for order=0 * thread, event_loop: thread flags callback refactor * cli: increase stack size * cli: rename cli_app_should_stop -> cli_is_pipe_broken_or_is_etx_next_char * cli: use plain array instead of mlib for history * cli: prepend file name to static fns * cli: fix formatting * cli_shell: increase stack size * cli_shell: give up pipe to command thread * fix formatting * fix: format * fix merge * fix. merge. * cli_shell: fix detach ordering * desktop: record_cli -> record_cli_vcp * cli: fix spelling, reload/remove ext cmds on card mount/unmount * cli: fix race conditions and formatting * scripts: wait for CTS to go high before starting flipper * scripts: better race condition fix * REVERT THIS: test script race condition fix * Revert "REVERT THIS: test script race condition fix" This reverts commit 3b028d29b07212755872c5706c8c6a58be551636. * REVERT THIS: test script fix * scripts: sleep? * cli: updated oplist for CliCommandTree * Revert "REVERT THIS: test script fix" This reverts commit e9846318549ce092ef422ff97522ba51916163be. * cli: mention memory leak in FL ticket --------- Co-authored-by: Georgii Surkov <georgii.surkov@outlook.com> Co-authored-by: あく <alleteam@gmail.com> Co-authored-by: hedger <hedger@nanode.su>
185 lines
5.6 KiB
C
185 lines
5.6 KiB
C
#include "cli.h"
|
|
#include "cli_i.h"
|
|
#include "cli_commands.h"
|
|
#include "cli_ansi.h"
|
|
#include <toolbox/pipe.h>
|
|
|
|
#define TAG "cli"
|
|
|
|
struct Cli {
|
|
CliCommandTree_t commands;
|
|
FuriMutex* mutex;
|
|
};
|
|
|
|
Cli* cli_alloc(void) {
|
|
Cli* cli = malloc(sizeof(Cli));
|
|
CliCommandTree_init(cli->commands);
|
|
cli->mutex = furi_mutex_alloc(FuriMutexTypeRecursive);
|
|
return cli;
|
|
}
|
|
|
|
void cli_add_command(
|
|
Cli* cli,
|
|
const char* name,
|
|
CliCommandFlag flags,
|
|
CliExecuteCallback callback,
|
|
void* context) {
|
|
cli_add_command_ex(cli, name, flags, callback, context, CLI_BUILTIN_COMMAND_STACK_SIZE);
|
|
}
|
|
|
|
void cli_add_command_ex(
|
|
Cli* cli,
|
|
const char* name,
|
|
CliCommandFlag flags,
|
|
CliExecuteCallback callback,
|
|
void* context,
|
|
size_t stack_size) {
|
|
furi_check(cli);
|
|
furi_check(name);
|
|
furi_check(callback);
|
|
|
|
// the shell always attaches the pipe to the stdio, thus both flags can't be used at once
|
|
if(flags & CliCommandFlagUseShellThread) furi_check(!(flags & CliCommandFlagDontAttachStdio));
|
|
|
|
FuriString* name_str;
|
|
name_str = furi_string_alloc_set(name);
|
|
// command cannot contain spaces
|
|
furi_check(furi_string_search_char(name_str, ' ') == FURI_STRING_FAILURE);
|
|
|
|
CliCommand command = {
|
|
.context = context,
|
|
.execute_callback = callback,
|
|
.flags = flags,
|
|
.stack_depth = stack_size,
|
|
};
|
|
|
|
furi_check(furi_mutex_acquire(cli->mutex, FuriWaitForever) == FuriStatusOk);
|
|
CliCommandTree_set_at(cli->commands, name_str, command);
|
|
furi_check(furi_mutex_release(cli->mutex) == FuriStatusOk);
|
|
|
|
furi_string_free(name_str);
|
|
}
|
|
|
|
void cli_delete_command(Cli* cli, const char* name) {
|
|
furi_check(cli);
|
|
FuriString* name_str;
|
|
name_str = furi_string_alloc_set(name);
|
|
furi_string_trim(name_str);
|
|
|
|
size_t name_replace;
|
|
do {
|
|
name_replace = furi_string_replace(name_str, " ", "_");
|
|
} while(name_replace != FURI_STRING_FAILURE);
|
|
|
|
furi_check(furi_mutex_acquire(cli->mutex, FuriWaitForever) == FuriStatusOk);
|
|
CliCommandTree_erase(cli->commands, name_str);
|
|
furi_check(furi_mutex_release(cli->mutex) == FuriStatusOk);
|
|
|
|
furi_string_free(name_str);
|
|
}
|
|
|
|
bool cli_get_command(Cli* cli, FuriString* command, CliCommand* result) {
|
|
furi_assert(cli);
|
|
furi_check(furi_mutex_acquire(cli->mutex, FuriWaitForever) == FuriStatusOk);
|
|
CliCommand* data = CliCommandTree_get(cli->commands, command);
|
|
if(data) *result = *data;
|
|
|
|
furi_check(furi_mutex_release(cli->mutex) == FuriStatusOk);
|
|
|
|
return !!data;
|
|
}
|
|
|
|
void cli_remove_external_commands(Cli* cli) {
|
|
furi_check(cli);
|
|
furi_check(furi_mutex_acquire(cli->mutex, FuriWaitForever) == FuriStatusOk);
|
|
|
|
// FIXME FL-3977: memory leak somewhere within this function
|
|
|
|
CliCommandTree_t internal_cmds;
|
|
CliCommandTree_init(internal_cmds);
|
|
for
|
|
M_EACH(item, cli->commands, CliCommandTree_t) {
|
|
if(!(item->value_ptr->flags & CliCommandFlagExternal))
|
|
CliCommandTree_set_at(internal_cmds, *item->key_ptr, *item->value_ptr);
|
|
}
|
|
CliCommandTree_move(cli->commands, internal_cmds);
|
|
|
|
furi_check(furi_mutex_release(cli->mutex) == FuriStatusOk);
|
|
}
|
|
|
|
void cli_enumerate_external_commands(Cli* cli) {
|
|
furi_check(cli);
|
|
furi_check(furi_mutex_acquire(cli->mutex, FuriWaitForever) == FuriStatusOk);
|
|
FURI_LOG_D(TAG, "Enumerating external commands");
|
|
|
|
cli_remove_external_commands(cli);
|
|
|
|
// iterate over files in plugin directory
|
|
Storage* storage = furi_record_open(RECORD_STORAGE);
|
|
File* plugin_dir = storage_file_alloc(storage);
|
|
|
|
if(storage_dir_open(plugin_dir, CLI_COMMANDS_PATH)) {
|
|
char plugin_filename[64];
|
|
FuriString* plugin_name = furi_string_alloc();
|
|
|
|
while(storage_dir_read(plugin_dir, NULL, plugin_filename, sizeof(plugin_filename))) {
|
|
FURI_LOG_T(TAG, "Plugin: %s", plugin_filename);
|
|
furi_string_set_str(plugin_name, plugin_filename);
|
|
furi_string_replace_all_str(plugin_name, ".fal", "");
|
|
furi_string_replace_at(plugin_name, 0, 4, ""); // remove "cli_" in the beginning
|
|
CliCommand command = {
|
|
.context = NULL,
|
|
.execute_callback = NULL,
|
|
.flags = CliCommandFlagExternal,
|
|
};
|
|
CliCommandTree_set_at(cli->commands, plugin_name, command);
|
|
}
|
|
|
|
furi_string_free(plugin_name);
|
|
}
|
|
|
|
storage_file_free(plugin_dir);
|
|
furi_record_close(RECORD_STORAGE);
|
|
|
|
FURI_LOG_D(TAG, "Finished enumerating external commands");
|
|
furi_check(furi_mutex_release(cli->mutex) == FuriStatusOk);
|
|
}
|
|
|
|
void cli_lock_commands(Cli* cli) {
|
|
furi_check(cli);
|
|
furi_check(furi_mutex_acquire(cli->mutex, FuriWaitForever) == FuriStatusOk);
|
|
}
|
|
|
|
void cli_unlock_commands(Cli* cli) {
|
|
furi_check(cli);
|
|
furi_check(furi_mutex_release(cli->mutex) == FuriStatusOk);
|
|
}
|
|
|
|
CliCommandTree_t* cli_get_commands(Cli* cli) {
|
|
furi_check(cli);
|
|
furi_check(furi_mutex_get_owner(cli->mutex) == furi_thread_get_current_id());
|
|
return &cli->commands;
|
|
}
|
|
|
|
bool cli_is_pipe_broken_or_is_etx_next_char(PipeSide* side) {
|
|
if(pipe_state(side) == PipeStateBroken) return true;
|
|
if(!pipe_bytes_available(side)) return false;
|
|
char c = getchar();
|
|
return c == CliKeyETX;
|
|
}
|
|
|
|
void cli_print_usage(const char* cmd, const char* usage, const char* arg) {
|
|
furi_check(cmd);
|
|
furi_check(arg);
|
|
furi_check(usage);
|
|
|
|
printf("%s: illegal option -- %s\r\nusage: %s %s", cmd, arg, cmd, usage);
|
|
}
|
|
|
|
void cli_on_system_start(void) {
|
|
Cli* cli = cli_alloc();
|
|
cli_commands_init(cli);
|
|
cli_enumerate_external_commands(cli);
|
|
furi_record_create(RECORD_CLI, cli);
|
|
}
|