moodle/local_webhooks
0
Fork 0
Code Issues Releases Activity

Added correct test delete record

Browse Source 
Signed-off-by: Valentin Popov <info@valentineus.link>
This commit is contained in:
Valentin Popov 2019-05-10 15:34:57 +04:00
parent e84ac6859a
commit 46711c9942
Signed by: Valentin Popov
GPG Key ID: 269A00ACA90A8EA3
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tests/api_test.php
View File

@ -52,6 +52,7 @@ final class local_webhooks_api_testcase extends advanced_testcase {
*/ */
private static function get_random_record(): record { private static function get_random_record(): record {
$record = new record(); $record = new record();
$record->events = self::get_random_events(); $record->events = self::get_random_events();
$record->header = 'application/json'; $record->header = 'application/json';
$record->name = uniqid('', false); $record->name = uniqid('', false);
@ -102,8 +103,6 @@ final class local_webhooks_api_testcase extends advanced_testcase {
/** /**
* Test deletion of the service. * Test deletion of the service.
* *
* @todo It's no testing all conditional.
*
* @group local_webhooks * @group local_webhooks
* *
* @throws \dml_exception * @throws \dml_exception
@ -115,12 +114,26 @@ final class local_webhooks_api_testcase extends advanced_testcase {
$this->resetAfterTest(); $this->resetAfterTest();
// Testing correct delete record of the database.
$record = self::get_random_record(); $record = self::get_random_record();
$record->id = api::add_service($record); $record->id = api::add_service($record);
self::assertTrue(api::del_service($record->id)); self::assertTrue(api::del_service($record->id));
self::assertCount(0, $DB->get_records(LW_TABLE_EVENTS)); self::assertCount(0, $DB->get_records(LW_TABLE_EVENTS));
self::assertCount(0, $DB->get_records(LW_TABLE_SERVICES)); self::assertCount(0, $DB->get_records(LW_TABLE_SERVICES));
// Testing correct delete record of the record's list.
$ids = [];
$total = random_int(5, 20);
for ($i = 0; $i < $total; $i++) {
$record = self::get_random_record();
$ids[] = api::add_service($record);
}
self::assertEquals(count($ids), api::get_total_count());
self::assertTrue(api::del_service($ids[array_rand($ids, 1)]));
self::assertEquals(count($ids) - 1, api::get_total_count());
} }
/** /**