moodle/local_webhooks
0
Fork 0
Code Issues Releases Activity

Correction of checks

Browse Source 
Signed-off-by: Valentin Popov <info@valentineus.link>
This commit is contained in:
Valentin Popov
2018-09-09 21:47:37 +04:00
parent c18d7107b9
commit 73f45578b3
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib.php
View File

@ -44,7 +44,7 @@ class local_webhooks_api {
public static function get_service( $serviceId = 0 ) { public static function get_service( $serviceId = 0 ) {
global $DB; global $DB;
if ( !is_numeric( $serviceId ) || empty( $serviceId ) ) { if ( empty( $serviceId ) || !is_numeric( $serviceId ) ) {
print_error( "unknowparamtype", "error", null, "serviceId" ); print_error( "unknowparamtype", "error", null, "serviceId" );
} }
@ -94,7 +94,7 @@ class local_webhooks_api {
public static function get_services_by_event( $eventName = "" ) { public static function get_services_by_event( $eventName = "" ) {
global $DB; global $DB;
if ( !is_string( $eventName ) || empty( $eventName ) ) { if ( empty( $eventName ) || !is_string( $eventName ) ) {
print_error( "unknowparamtype", "error", null, "eventName" ); print_error( "unknowparamtype", "error", null, "eventName" );
} }
@ -117,12 +117,12 @@ class local_webhooks_api {
public static function create_service( $service = array() ) { public static function create_service( $service = array() ) {
global $DB; global $DB;
if ( !is_array( $service ) || empty( $service ) ) { if ( empty( $service ) || !is_array( $service ) ) {
print_error( "unknowparamtype", "error", null, "service" ); print_error( "unknowparamtype", "error", null, "service" );
} }
$serviceId = $DB->insert_record( LW_TABLE_SERVICES, $service, true, false ); $serviceId = $DB->insert_record( LW_TABLE_SERVICES, $service, true, false );
if ( $serviceId && is_array( $service[ "events" ] ) && !empty( $service[ "events" ] ) ) { if ( $serviceId && !empty( $service[ "events" ] ) && is_array( $service[ "events" ] ) ) {
self::insert_events( $service[ "events" ], $serviceId ); self::insert_events( $service[ "events" ], $serviceId );
} }
@ -140,7 +140,7 @@ class local_webhooks_api {
public static function delete_service( $serviceId = 0 ) { public static function delete_service( $serviceId = 0 ) {
global $DB; global $DB;
if ( !is_numeric( $serviceId ) || empty( $serviceId ) ) { if ( empty( $serviceId ) || !is_numeric( $serviceId ) ) {
print_error( "unknowparamtype", "error", null, "serviceId" ); print_error( "unknowparamtype", "error", null, "serviceId" );
} }
@ -159,14 +159,14 @@ class local_webhooks_api {
public static function update_service( $service = array() ) { public static function update_service( $service = array() ) {
global $DB; global $DB;
if ( !is_array( $service ) || empty( $service ) || empty( $service[ "id" ] ) ) { if ( empty( $service ) || !is_array( $service ) || empty( $service[ "id" ] ) ) {
print_error( "unknowparamtype", "error", null, "service" ); print_error( "unknowparamtype", "error", null, "service" );
} }
// TODO: Add transactions for operations // TODO: Add transactions for operations
$result = $DB->update_record( LW_TABLE_SERVICES, $service, false ); $result = $DB->update_record( LW_TABLE_SERVICES, $service, false );
$DB->delete_records( LW_TABLE_EVENTS, array( "serviceid" => $service[ "id" ] ) ); $DB->delete_records( LW_TABLE_EVENTS, array( "serviceid" => $service[ "id" ] ) );
if ( $result && is_array( $service[ "events" ] ) && !empty( $service[ "events" ] ) ) { if ( $result && !empty( $service[ "events" ] ) && is_array( $service[ "events" ] ) ) {
self::insert_events( $service[ "events" ], $service[ "id" ] ); self::insert_events( $service[ "events" ], $service[ "id" ] );
} }