Aesthetics in the code

classes/editform.php

@@ -28,9 +28,9 @@ defined("MOODLE_INTERNAL") || die();
 
 require_once($CFG->libdir . "/formslib.php");
 
-use report_eventlist_list_generator;
 use lang_string;
 use moodleform;
+use report_eventlist_list_generator;
 
 /**
  * Description editing form definition.

classes/event/response_get.php

@@ -37,9 +37,9 @@ class response_get extends \core\event\base {
      * Init method.
      */
     protected function init() {
-        $this->data["crud"] = "u";
+        $this->data["crud"]        = "r";
-        $this->data["objecttable"] = "local_webhooks_service";
         $this->data["edulevel"]    = self::LEVEL_OTHER;
+        $this->data["objecttable"] = "local_webhooks_service";
     }
 
     /**

classes/handler.php

@@ -125,7 +125,8 @@ class handler {
                 "other"    => array(
                     "status" => $status
                 )
-        ));
+            )
+        );
 
         $event->trigger();
     }

db/events.php

@@ -26,10 +26,10 @@ defined("MOODLE_INTERNAL") || die();
 
 $observers = array(
     array(
-        "eventname" => "*",
         "callback"    => "\local_webhooks\\handler::events",
+        "eventname"   => "*",
         "includefile" => null,
-        "priority" => 200,
+        "internal"    => true,
-        "internal" => true
+        "priority"    => 200
     )
 );

editservice.php

@@ -27,11 +27,11 @@ require_once(__DIR__ . "/classes/editform.php");
 require_once($CFG->libdir . "/adminlib.php");
 
 admin_externalpage_setup("pluginsoverview");
-
-$serviceid = optional_param("serviceid", 0, PARAM_INT);
-
 require_login();
 
+/* Optional parameters */
+$serviceid = optional_param("serviceid", 0, PARAM_INT);
+
 /* Link generation */
 $urlparameters  = array("serviceid" => $serviceid);
 $managerservice = new moodle_url("/local/webhooks/managerservice.php", $urlparameters);
@@ -62,10 +62,13 @@ if ($editing = boolval($serviceid)) {
 
 /* Processing of received data */
 if ($data = $mform->get_data()) {
-    if (!empty($data->events)) {
+    if (empty($data->events)) {
-        $data->events = base64_encode(gzcompress(serialize($data->events), 9));
+        $data->events = array();
     }
 
+    /* Pack the list of events */
+    $data->events = base64_encode(gzcompress(serialize($data->events), 9));
+
     if ($editing) {
         $data->id = $serviceid;
         $DB->update_record("local_webhooks_service", $data);
@@ -82,7 +85,7 @@ $PAGE->set_heading($titlepage);
 $PAGE->set_title($titlepage);
 
 /* The page title */
-$PAGE->navbar->add(new lang_string("externalservices", "webservice"), $managerservice);
+$PAGE->navbar->add(new lang_string("pluginname", "local_webhooks"), $managerservice);
 $PAGE->navbar->add($titlepage);
 echo $OUTPUT->header();
 

managerservice.php

@@ -27,13 +27,14 @@ require_once($CFG->libdir . "/tablelib.php");
 require_once($CFG->libdir . "/adminlib.php");
 
 admin_externalpage_setup("pluginsoverview");
+require_login();
 
-$backupservices = optional_param("backup", 0, PARAM_BOOL);
+/* Optional parameters */
+$backupservices = optional_param("getbackup", 0, PARAM_BOOL);
 $deleteid       = optional_param("deleteid", 0, PARAM_INT);
 $hideshowid     = optional_param("hideshowid", 0, PARAM_INT);
 
-require_login();
+/* Used references */
-
 $editservice    = "/local/webhooks/editservice.php";
 $managerservice = "/local/webhooks/managerservice.php";
 $restorebackup  = "/local/webhooks/restorebackup.php";
@@ -74,7 +75,7 @@ if (boolval($hideshowid) && confirm_sesskey()) {
 }
 
 /* Page template */
-$titlepage = new lang_string("externalservices", "webservice");
+$titlepage = new lang_string("pluginname", "local_webhooks");
 $PAGE->set_pagelayout("admin");
 $PAGE->set_title($titlepage);
 $PAGE->set_heading($titlepage);
@@ -125,11 +126,11 @@ foreach ($callbacks as $callback) {
 $table->print_html();
 
 /* Add service button */
-$addurl = new moodle_url($editservice);
+$addserviceurl = new moodle_url($editservice);
-echo $OUTPUT->single_button($addurl, new lang_string("addaservice", "webservice"), "get");
+echo $OUTPUT->single_button($addserviceurl, new lang_string("addaservice", "webservice"), "get");
 
 /* Button to get a backup */
-$backupurl = new moodle_url($managerservice, array("backup" => true));
+$backupurl = new moodle_url($managerservice, array("getbackup" => true));
 echo $OUTPUT->single_button($backupurl, new lang_string("backup", "moodle"), "get");
 
 /* Button for restoring settings */

restorebackup.php

@@ -67,7 +67,7 @@ $PAGE->set_heading($titlepage);
 $PAGE->set_title($titlepage);
 
 /* The page title */
-$PAGE->navbar->add(new lang_string("externalservices", "webservice"), $managerservice);
+$PAGE->navbar->add(new lang_string("pluginname", "local_webhooks"), $managerservice);
 $PAGE->navbar->add($titlepage);
 echo $OUTPUT->header();
 

settings.php

@@ -26,7 +26,7 @@ defined("MOODLE_INTERNAL") || die();
 
 if ($hassiteconfig) {
     $ADMIN->add("server", new admin_externalpage("local_webhooks",
-        new lang_string("externalservices", "webservice"),
+        new lang_string("pluginname", "local_webhooks"),
         new moodle_url("/local/webhooks/managerservice.php")
     ));
 }