valentineus/0xFFFF
1
Fork 0
Code Releases Activity

main: Use snprintf instead sprintf and initialize buffer to NULL term

Browse Source
This commit is contained in:
Pali Rohár committed 2014-10-19 20:18:47 +02:00
1 parent a8986bf631
commit 8d52950ede
1 file changed
+6 -3
Download Patch File Download Diff File Expand all files Collapse all files
src/main.c
+6 -3
View File
@@ -1210,7 +1210,8 @@ int main(int argc, char **argv) {
if ( ! image_tmp_name(i) )
continue;
sprintf(buf, "%hd", dev->detected_hwrev);
buf[0] = 0;
snprintf(buf, sizeof(buf), "%hd", dev->detected_hwrev);
switch ( i ) {
case IMAGE_2ND:
@@ -1312,14 +1313,16 @@ int main(int argc, char **argv) {
break;
}
sprintf(buf, "%s-%s:%hd_%s", image_type_to_string(i), device_to_string(dev->detected_device), dev->detected_hwrev, ptr);
buf[0] = 0;
snprintf(buf, sizeof(buf), "%s-%s:%hd_%s", image_type_to_string(i), device_to_string(dev->detected_device), dev->detected_hwrev, ptr);
printf("Renaming %s image file to %s...\n", image_type_to_string(i), buf);
if ( rename(image_tmp_name(i), buf) < 0 ) {
ERROR_INFO("Renaming failed");
sprintf(buf, "%s-%s_%s", image_type_to_string(i), device_to_string(dev->detected_device), ptr);
buf[0] = 0;
snprintf(buf, sizeof(buf), "%s-%s_%s", image_type_to_string(i), device_to_string(dev->detected_device), ptr);
printf("Trying to rename %s image file to %s...\n", image_type_to_string(i), buf);
if ( rename(image_tmp_name(i), buf) < 0 )