valentineus/0xFFFF
1
Fork 0
Code Releases Activity

local: Check return value of snprintf

Browse Source
This commit is contained in:
Pali Rohár committed 2014-10-19 20:18:02 +02:00
1 parent 9a1f63c5ae
commit a8986bf631
1 file changed
+8 -4
Download Patch File Download Diff File Expand all files Collapse all files
src/local.c
+8 -4
View File
@@ -316,7 +316,8 @@ int local_dump_image(enum image_type image, const char * file) {
while ( ( dirent = readdir(dir) ) ) { while ( ( dirent = readdir(dir) ) ) {
snprintf(buf, sizeof(buf), "/sys/class/mmc_host/%s/slot_name", dirent->d_name); if ( snprintf(buf, sizeof(buf), "/sys/class/mmc_host/%s/slot_name", dirent->d_name) <= 0 )
continue;
fd = open(buf, O_RDONLY); fd = open(buf, O_RDONLY);
if ( fd < 0 ) if ( fd < 0 )
@@ -330,7 +331,8 @@ int local_dump_image(enum image_type image, const char * file) {
if ( strncmp(buf, "internal", strlen("internal")) != 0 ) if ( strncmp(buf, "internal", strlen("internal")) != 0 )
continue; continue;
snprintf(buf, sizeof(buf), "/sys/class/mmc_host/%s/%s:0001/", dirent->d_name, dirent->d_name); if ( snprintf(buf, sizeof(buf), "/sys/class/mmc_host/%s/%s:0001/", dirent->d_name, dirent->d_name) <= 0 )
continue;
dir2 = opendir(buf); dir2 = opendir(buf);
if ( ! dir2 ) if ( ! dir2 )
@@ -341,7 +343,8 @@ int local_dump_image(enum image_type image, const char * file) {
if ( strncmp(dirent2->d_name, "block:mmcblk", strlen("block:mmcblk")) != 0 ) if ( strncmp(dirent2->d_name, "block:mmcblk", strlen("block:mmcblk")) != 0 )
continue; continue;
snprintf(buf, sizeof(buf), "/sys/class/mmc_host/%s/%s:0001/%s/dev", dirent->d_name, dirent->d_name, dirent2->d_name); if ( snprintf(buf, sizeof(buf), "/sys/class/mmc_host/%s/%s:0001/%s/dev", dirent->d_name, dirent->d_name, dirent2->d_name) <= 0 )
continue;
f = fopen(buf, "r"); f = fopen(buf, "r");
if ( ! f ) if ( ! f )
@@ -385,7 +388,8 @@ int local_dump_image(enum image_type image, const char * file) {
while ( ( dirent = readdir(dir) ) ) { while ( ( dirent = readdir(dir) ) ) {
snprintf(buf, sizeof(buf), "/dev/%s", dirent->d_name); if ( snprintf(buf, sizeof(buf), "/dev/%s", dirent->d_name) <= 0 )
continue;
if ( stat(buf, &st) != 0 ) if ( stat(buf, &st) != 0 )
continue; continue;