Merge pull request #5 from valentineus/release/2020-06-17

release/2020-06-17

.github/workflows/publish.yml

@@ -13,7 +13,7 @@ jobs:
       - uses: actions/setup-node@v1
         with:
           node-version: '13.x'
-      - run: yarn install
+      - run: npm install
-      - run: yarn run build
+      - run: npm run build
       - run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_AUTH_TOKEN }}" > ~/.npmrc
       - run: npm publish

.gitignore

@@ -198,9 +198,5 @@ $RECYCLE.BIN/
 ### Project ###
 
 # Resulting code
-/_tslib-*.js
+/*.js
-/default-*.js
+
-/javascript.js
-/typescript.js
-/vue-javascript.js
-/vue-typescript.js

ROADMAP.md

@@ -13,7 +13,6 @@
 - [ ] "block-scoped-var"
 - [ ] "block-spacing"
 - [X] "brace-style"
-- [X] "callback-return"
 - [X] "camelcase"
 - [ ] "capitalized-comments"
 - [X] "class-methods-use-this"
@@ -42,10 +41,8 @@
 - [ ] "function-paren-newline"
 - [ ] "generator-star-spacing"
 - [ ] "getter-return"
-- [ ] "global-require"
 - [ ] "grouped-accessor-pairs"
 - [ ] "guard-for-in"
-- [X] "handle-callback-err"
 - [ ] "id-blacklist"
 - [X] "id-length"
 - [ ] "id-match"
@@ -138,10 +135,10 @@
 - [X] "no-lone-blocks"
 - [ ] "no-lonely-if"
 - [ ] "no-loop-func"
+- [ ] "no-loss-of-precision"
 - [X] "no-magic-numbers"
 - [ ] "no-misleading-character-class"
 - [ ] "no-mixed-operators"
-- [ ] "no-mixed-requires"
 - [X] "no-mixed-spaces-and-tabs"
 - [ ] "no-multi-assign"
 - [X] "no-multi-spaces"
@@ -154,17 +151,13 @@
 - [ ] "no-new"
 - [X] "no-new-func"
 - [ ] "no-new-object"
-- [X] "no-new-require"
 - [ ] "no-new-symbol"
 - [X] "no-new-wrappers"
 - [ ] "no-obj-calls"
 - [ ] "no-octal"
 - [X] "no-octal-escape"
 - [ ] "no-param-reassign"
-- [X] "no-path-concat"
 - [ ] "no-plusplus"
-- [X] "no-process-env"
-- [ ] "no-process-exit"
 - [X] "no-proto"
 - [ ] "no-prototype-builtins"
 - [ ] "no-redeclare"
@@ -172,7 +165,6 @@
 - [ ] "no-restricted-exports"
 - [ ] "no-restricted-globals"
 - [ ] "no-restricted-imports"
-- [ ] "no-restricted-modules"
 - [X] "no-restricted-properties"
 - [ ] "no-restricted-syntax"
 - [ ] "no-return-assign"
@@ -186,7 +178,6 @@
 - [ ] "no-shadow-restricted-names"
 - [X] "no-spaced-func"
 - [ ] "no-sparse-arrays"
-- [ ] "no-sync"
 - [X] "no-tabs"
 - [ ] "no-template-curly-in-string"
 - [X] "no-ternary"
@@ -291,6 +282,7 @@
 - [X] "no-unused-disable"
 - [X] "no-unused-enable"
 - [X] "no-use"
+- [ ] "require-description"
 
 ## Import
 
@@ -316,6 +308,7 @@
 - [ ] "no-dynamic-require"
 - [ ] "no-extraneous-dependencies"
 - [ ] "no-internal-modules"
+- [ ] "no-loss-of-precision"
 - [ ] "no-mutable-exports"
 - [ ] "no-named-as-default"
 - [ ] "no-named-as-default-member"
@@ -385,29 +378,31 @@
 - [ ] "array-type"
 - [X] "await-thenable"
 - [ ] "ban-ts-comment"
-- [ ] "ban-ts-ignore"
+- [ ] "ban-tslint-comment"
 - [ ] "ban-types"
 - [ ] "brace-style"
 - [ ] "camelcase"
 - [X] "class-literal-property-style"
-- [ ] "class-name-casing"
 - [X] "comma-spacing"
 - [ ] "consistent-type-assertions"
 - [ ] "consistent-type-definitions"
 - [ ] "default-param-last"
+- [ ] "dot-notation"
 - [X] "explicit-function-return-type"
 - [X] "explicit-member-accessibility"
 - [ ] "explicit-module-boundary-types"
 - [ ] "func-call-spacing"
-- [ ] "generic-type-naming"
 - [X] "indent"
-- [X] "interface-name-prefix"
+- [ ] "init-declarations"
+- [ ] "keyword-spacing"
+- [ ] "lines-between-class-members"
 - [ ] "member-delimiter-style"
-- [ ] "member-naming"
 - [ ] "member-ordering"
+- [X] "method-signature-style"
 - [ ] "naming-convention"
 - [ ] "no-array-constructor"
 - [X] "no-base-to-string"
+- [ ] "no-confusing-non-null-assertion"
 - [ ] "no-dupe-class-members"
 - [ ] "no-dynamic-delete"
 - [ ] "no-empty-function"
@@ -421,6 +416,8 @@
 - [ ] "no-for-in-array"
 - [X] "no-implied-eval"
 - [X] "no-inferrable-types"
+- [ ] "no-invalid-this"
+- [ ] "no-invalid-void-type"
 - [X] "no-magic-numbers"
 - [ ] "no-misused-new"
 - [X] "no-misused-promises"
@@ -437,10 +434,10 @@
 - [ ] "no-unnecessary-qualifier"
 - [ ] "no-unnecessary-type-arguments"
 - [X] "no-unnecessary-type-assertion"
+- [ ] "no-unsafe-assignment"
 - [X] "no-unsafe-call"
 - [X] "no-unsafe-member-access"
 - [X] "no-unsafe-return"
-- [X] "no-untyped-public-signature"
 - [ ] "no-unused-expressions"
 - [X] "no-unused-vars"
 - [X] "no-unused-vars-experimental"
@@ -456,8 +453,10 @@
 - [ ] "prefer-optional-chain"
 - [ ] "prefer-readonly"
 - [X] "prefer-readonly-parameter-types"
+- [ ] "prefer-reduce-type-parameter"
 - [ ] "prefer-regexp-exec"
 - [ ] "prefer-string-starts-ends-with"
+- [ ] "prefer-ts-expect-error"
 - [ ] "promise-function-async"
 - [X] "quotes"
 - [ ] "require-array-sort-compare"
@@ -497,13 +496,17 @@
 - [ ] "no-keyword-prefix"
 - [ ] "no-nested-ternary"
 - [ ] "no-new-buffer"
+- [ ] "no-null"
 - [ ] "no-process-exit"
+- [ ] "no-reduce"
 - [ ] "no-unreadable-array-destructuring"
 - [ ] "no-unsafe-regex"
 - [ ] "no-unused-properties"
+- [ ] "no-useless-undefined"
 - [ ] "no-zero-fractions"
 - [ ] "number-literal-case"
 - [ ] "prefer-add-event-listener"
+- [ ] "prefer-array-find"
 - [ ] "prefer-dataset"
 - [ ] "prefer-event-key"
 - [ ] "prefer-exponentiation-operator"
@@ -514,6 +517,7 @@
 - [ ] "prefer-node-append"
 - [ ] "prefer-node-remove"
 - [X] "prefer-number-properties"
+- [ ] "prefer-optional-catch-binding"
 - [ ] "prefer-query-selector"
 - [ ] "prefer-reflect-apply"
 - [ ] "prefer-replace-all"
@@ -525,6 +529,7 @@
 - [ ] "prefer-trim-start-end"
 - [ ] "prefer-type-error"
 - [X] "prevent-abbreviations"
+- [ ] "string-content"
 - [ ] "throw-new-error"
 
 ## Vue

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@valentineus/eslint-config",
-  "version": "0.0.15",
+  "version": "0.0.16",
   "description": "Personal ESLint configuration",
   "main": "index.js",
   "repository": "git@code.valentineus.link:eslint-config.git",
@@ -11,31 +11,32 @@
     "build": "rollup --config rollup.config.js"
   },
   "devDependencies": {
-    "@rollup/plugin-json": "^4.0.2",
+    "@rollup/plugin-json": "^4.1.0",
-    "@rollup/plugin-typescript": "^3.0.0",
+    "@rollup/plugin-typescript": "^4.1.2",
-    "@typescript-eslint/eslint-plugin": "^2.26.0",
+    "@types/node": "^14.0.13",
-    "@typescript-eslint/parser": "^2.26.0",
+    "@typescript-eslint/eslint-plugin": "^3.3.0",
-    "eslint": "^6.8.0",
+    "@typescript-eslint/parser": "^3.3.0",
-    "eslint-plugin-eslint-comments": "^3.1.2",
+    "eslint": "^7.2.0",
-    "eslint-plugin-import": "^2.20.2",
+    "eslint-plugin-eslint-comments": "^3.2.0",
+    "eslint-plugin-import": "^2.21.2",
     "eslint-plugin-security": "^1.4.0",
     "eslint-plugin-sonarjs": "^0.5.0",
-    "eslint-plugin-unicorn": "^18.0.1",
+    "eslint-plugin-unicorn": "^20.1.0",
     "eslint-plugin-vue": "^6.2.2",
-    "rollup": "^1.31.1",
+    "rollup": "^2.17.0",
-    "rollup-plugin-terser": "^5.2.0",
+    "rollup-plugin-terser": "^6.1.0",
-    "tslib": "^1.10.0",
+    "tslib": "^2.0.0",
-    "typescript": "^3.7.5"
+    "typescript": "^3.9.5"
   },
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.26.0",
+    "@typescript-eslint/eslint-plugin": "^3.3.0",
-    "@typescript-eslint/parser": "^2.26.0",
+    "@typescript-eslint/parser": "^3.3.0",
-    "eslint": "^6.8.0",
+    "eslint": "^7.2.0",
-    "eslint-plugin-eslint-comments": "^3.1.2",
+    "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-import": "^2.20.2",
+    "eslint-plugin-import": "^2.21.2",
     "eslint-plugin-security": "^1.4.0",
     "eslint-plugin-sonarjs": "^0.5.0",
-    "eslint-plugin-unicorn": "^18.0.1",
+    "eslint-plugin-unicorn": "^20.1.0",
     "eslint-plugin-vue": "^6.2.2"
   },
   "dependencies": {}

rollup.config.js

@@ -1,6 +1,6 @@
-import { terser } from "rollup-plugin-terser";
 import json from "@rollup/plugin-json";
 import typescript from "@rollup/plugin-typescript";
+import { terser } from "rollup-plugin-terser";
 
 module.exports = {
 	input: {
@@ -25,7 +25,6 @@ module.exports = {
 			output: {
 				comments: false,
 			},
-			sourcemap: false,
 		}),
 	],
 };

src/rules/javascript/default.json

@@ -2,7 +2,8 @@
   "array-callback-return": [
     "error",
     {
-      "allowImplicit": false
+      "allowImplicit": false,
+      "checkForEach": true
     }
   ],
   "arrow-parens": [
@@ -23,9 +24,6 @@
       "allowSingleLine": false
     }
   ],
-  "callback-return": [
-    "warn"
-  ],
   "camelcase": [
     "error",
     {
@@ -53,10 +51,7 @@
   ],
   "comma-style": [
     "error",
-    "last",
+    "last"
-    {
-      "exceptions": {}
-    }
   ],
   "curly": [
     "error",
@@ -80,9 +75,6 @@
     "error",
     "consistent"
   ],
-  "handle-callback-err": [
-    "error"
-  ],
   "id-length": [
     "warn",
     {
@@ -114,7 +106,7 @@
       "VariableDeclarator": 1,
       "flatTernaryExpressions": true,
       "ignoreComments": false,
-      "ignoredNodes": [],
+      "offsetTernaryExpressions": true,
       "outerIIFEBody": 1
     }
   ],
@@ -330,9 +322,6 @@
   "no-new-func": [
     "error"
   ],
-  "no-new-require": [
-    "error"
-  ],
   "no-new-wrappers": [
     "error"
   ],
@@ -345,12 +334,6 @@
       "props": true
     }
   ],
-  "no-path-concat": [
-    "error"
-  ],
-  "no-process-env": [
-    "off"
-  ],
   "no-proto": [
     "error"
   ],
@@ -469,9 +452,22 @@
   "object-curly-newline": [
     "error",
     {
-      "consistent": true,
+      "ExportDeclaration": {
-      "minProperties": 5,
+        "consistent": true,
-      "multiline": true
+        "minProperties": 1,
+        "multiline": true
+      },
+      "ImportDeclaration": "never",
+      "ObjectExpression": {
+        "consistent": true,
+        "minProperties": 1,
+        "multiline": true
+      },
+      "ObjectPattern": {
+        "consistent": true,
+        "minProperties": 1,
+        "multiline": true
+      }
     }
   ],
   "object-curly-spacing": [

src/rules/typescript/default.json

@@ -16,6 +16,7 @@
   "@typescript-eslint/explicit-function-return-type": [
     "error",
     {
+      "allowConciseArrowFunctionExpressionsStartingWithVoid": false,
       "allowExpressions": false,
       "allowHigherOrderFunctions": false,
       "allowTypedFunctionExpressions": false
@@ -61,12 +62,9 @@
       "outerIIFEBody": 1
     }
   ],
-  "@typescript-eslint/interface-name-prefix": [
+  "@typescript-eslint/method-signature-style": [
     "error",
-    {
+    "property"
-      "allowUnderscorePrefix": false,
-      "prefixWithI": "always"
-    }
   ],
   "@typescript-eslint/no-base-to-string": [
     "error"
@@ -125,9 +123,7 @@
   "@typescript-eslint/no-unnecessary-condition": [
     "error",
     {
-      "allowConstantLoopConditions": false,
+      "allowConstantLoopConditions": false
-      "checkArrayPredicates": true,
-      "ignoreRhs": true
     }
   ],
   "@typescript-eslint/no-unnecessary-type-assertion": [
@@ -142,14 +138,6 @@
   "@typescript-eslint/no-unsafe-return": [
     "error"
   ],
-  "@typescript-eslint/no-untyped-public-signature": [
-    "warn",
-    {
-      "ignoredMethods": [
-        "constructor"
-      ]
-    }
-  ],
   "@typescript-eslint/no-unused-vars": [
     "error",
     {
@@ -213,9 +201,13 @@
   "@typescript-eslint/strict-boolean-expressions": [
     "error",
     {
-      "allowNullable": false,
+      "allowAny": false,
-      "allowSafe": false,
+      "allowNullableBoolean": false,
-      "ignoreRhs": false
+      "allowNullableNumber": false,
+      "allowNullableObject": false,
+      "allowNullableString": false,
+      "allowNumber": false,
+      "allowString": false
     }
   ],
   "@typescript-eslint/type-annotation-spacing": [

src/typescript.ts

@@ -3,7 +3,6 @@ import rDefault from "./rules/typescript/default.json";
 module.exports = {
 	"extends": [
 		"./javascript",
-		"plugin:@typescript-eslint/eslint-recommended",
 		"plugin:@typescript-eslint/recommended",
 		"plugin:@typescript-eslint/recommended-requiring-type-checking",
 		"plugin:import/typescript",
@@ -15,5 +14,7 @@ module.exports = {
 	"plugins": [
 		"@typescript-eslint",
 	],
-	"rules": { ...rDefault },
+	"rules": {
+		...rDefault,
+	},
 };

src/vue-javascript.ts

@@ -14,7 +14,9 @@ module.exports = {
 			files: [
 				"*.vue",
 			],
-			rules: { ...rOverrides },
+			rules: {
+				...rOverrides,
+			},
 		},
 	],
 	"parser": "vue-eslint-parser",
@@ -24,5 +26,7 @@ module.exports = {
 		],
 	},
 	"plugins": ["vue"],
-	"rules": { ...rDefault },
+	"rules": {
+		...rDefault,
+	},
 };

src/vue-typescript.ts

@@ -14,7 +14,9 @@ module.exports = {
 			files: [
 				"*.vue",
 			],
-			rules: { ...rOverrides },
+			rules: {
+				...rOverrides,
+			},
 		},
 	],
 	"parser": "vue-eslint-parser",
@@ -26,5 +28,7 @@ module.exports = {
 		parser: "@typescript-eslint/parser",
 	},
 	"plugins": ["vue"],
-	"rules": { ...rDefault },
+	"rules": {
+		...rDefault,
+	},
 };